Skip to content

Separate Redux and standalone example #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 29, 2019
Merged

Separate Redux and standalone example #48

merged 5 commits into from
Nov 29, 2019

Conversation

AlexandraBuzila
Copy link
Member

  • separate examples
  • update app layout
  • add custom renderer in standalone example

@AlexandraBuzila
Separate Redux and standalone example
6599f3f 
- separate examples
- update app layout
- add custom renderer in standalone example
@AlexandraBuzila
Update package versions
1272a5a
@AlexandraBuzila
Pass cells to standalone example
4d0e24c
sdirix
sdirix requested changes Nov 29, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you check the formatting? Somehow the files are formatted differently, e.g. compare App.tsx with RatingControl.tsx. It would be great to have the same formatting everywhere.

sdirix
sdirix approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes ;)

@sdirix sdirix merged commit 6cc1279 into eclipsesource:master Nov 29, 2019
@AlexandraBuzila AlexandraBuzila deleted the separate-redux-standalone branch January 23, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandraBuzila @sdirix