Request to warn only severe errors (like syntax)

[SarahIluvatariel]

I've noticed that the built-in jshint sometimes differentiates between errors and warnings. (Although it's a little inconsistent/buggy. And then it reports them all as warnings in the end.) So...

I would love to be able to configure (quickly toggle) the severity level of jshint-eclipse so that it only reports the more severe errors (like syntax errors). Or, alternatively, to report severe javascript errors as eclipse errors and less severe ones as eclipse warnings.

This would probably require a modification to the built-in jshint...

Personally, I use VIM for my javascript needs, and it hooks in to jshint.js (using my modified version of the eclim plugin) to validate and display warnings. So I've also modified jshint.js to already do this (differentiate between errors and warnings) for my configuration of VIM. But the rest of the team of developers I work with uses eclipse. So I thought it might be useful for them, too.

(By the way, thanks for your excellent project! Jshint-Eclipse has come in very handy for us. :) )

(Also, I was going to attempt to create a fork of your project to do this, but I couldn't figure out how to build it. Keep getting errors. Any specific instructions for building and testing jshint-eclipse? I'm a newbie eclipse-plugin developer.)

[ralfstx]

I'd love to distinguish between errors and warnings as well. How does your modified jshint indicate errors? Do you use the error.code field? If you open an issue against jshint to distinguish between errors and warnings, please leave a pointer here.

If there's a way to support your custom jshint version in jshint-eclipse, feel free to fork and submit a pull request (including a test case). In case the error.code field is unique, we could also allow the user to configure a list of those errors that should be reported as warnings, and one list for those that are considered errors. Codes that aren't included in any of these lists are would be ignored. What do you think?

For building, you should be able to do a cd releng/com.eclipsesource.jshint.build and mvn clean package.

[SarahIluvatariel]

Hi. Thanks for your response.

I realized that I didn't have maven installed, so that was probably part of the problem. I installed it, and ran those two commands, but I'm still getting a lot of errors in eclipse. I think it can't find junit.... maybe I need to install maven in a different location?

So... instead, I just uploaded my own version of jshint to my own repository. I'll try to send that as a pull request to you, and you can take a look at it (compare it to r12 to see the differences), and if you like any of it, you can use it. or if you don't, that's fine too. I'm definitely not well-versed in jshint, so it's probably just a hack. You may know of a cleaner/better way to do it.

Maybe some day I'll figure out how to get rid of all the errors in eclipse and be able to contribute to this particular issue better. :) I don't set up new projects in eclipse every day, so I maybe I've got something configured wrong.

Thanks for considering my request! :)
~Sarah

[ben8p]

@ralfstx: to check if it's an error or a warning you have to use "code", if it contain a W (liek W000) it's a warning, with a E it's an error.
I made this change on a fork of your plugin : https://github.com/ben8p/jshint-eclipse/commit/8970fc5ac110e60ba9c11bc2303ec3819445dfda

For removing some warning, I did it differently. I added a text field wich contain 1 reg exp per line.
The during the "check" process I look if the regexp match the current "reason". If yes I ignore it :
https://github.com/ben8p/jshint-eclipse/commit/7c53821ae8b5966271b9539341a3663ba3c3c260#diff-33

@SarahIluvatariel : you should propose your eqbool to the jshint team http://www.jshint.com/hack/

(note 1: i a definitivly not a Java developer so my code can look odd)
(note 2: like Sarah, i was unable to configure the plugin with maven so I just removed the maven part from my fork, it's easier for newbies like me ;) )

[ralfstx]

@ben8p Thanks for your explanation. As a first step, I'd be happy to include your change (https://github.com/ben8p/jshint-eclipse/commit/8970fc5ac110e60ba9c11bc2303ec3819445dfda) in jshint-eclipse, but without the custom jshint version. Since your fork does not change the license in the README file, I assume that you agree to contribute your changes under the terms of the EPL?

[ben8p]

Sure :)
Feel free to include my changes :)

Thx for all the work you did :)

Ben
Le 13 avr. 2013 12:47, "Ralf Sternberg" notifications@github.com a écrit :

@ben8p https://github.com/ben8p Thanks for your explanation. As a first
step, I'd be happy to include your change (ben8p@8970fc5https://github.com/ben8p/jshint-eclipse/commit/8970fc5ac110e60ba9c11bc2303ec3819445dfda)
in jshint-eclipse, but without the custom jshint version. Since your fork
does not change the license in the README file, I assume that you agree to
contribute your changes under the terms of the EPL?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-16331102
.

[ralfstx]

@ben8p I finally managed to include a slighty modified version of your suggested change for errors/warnings. Thanks again for this contribution!