Bazel Eclipse doesn't recognize filegroup #15
Conversation
| if ((segments.length > (i + 1)) && "resources".equals(segments[i + 1])) { | ||
| path = path.append(segments[i + 1]); | ||
| } | ||
| return path; |
There was a problem hiding this comment.
This change seems unrelated to filegroup support. Please remove it. The java/resources structure is something that we did not intend to support automatically because it's uncommon and IntelliJ does not support it either. We should change the examples instead to not use this.
There was a problem hiding this comment.
The java/resources structure is something that we did not intend to support automatically because it's uncommon and IntelliJ does not support it either. We should change the examples instead to not use this.
I have tested the project that you created - module1/BUILD
The large contains 241 the java/resources folders.
This change seems unrelated to filegroup support. Please remove it.
If I remove that change the resources source folder in https://github.com/salesforce/bazel-ls-demo-project/blob/40a1357b6f0816fb46780710aa742b088e66b6fc/small/module1/BUILD#L8 won't be added. Bazel Eclipse shows the following error:
"Cannot nest 'module1/java/src' inside 'module1/java'. To enable the nesting exclude 'src/' from 'module1/java'"
I have removed the change and updated the small project - small
| return toJavaSourceFileOrLabelEntry(src); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I like the idea of supporting filegroup within the same package. This should be doable. But we need to make it proper and figure out a way to add all possible sources that way. Just one might not be sufficient.
There was a problem hiding this comment.
Do you have any example of such a source?
There was a problem hiding this comment.
When the filegroup is a glob matching to multiple .java files. Bazel should give multiple entries as input in response.
snjeza
force-pushed
the
issue-14
branch
2 times, most recently
from
94bf2bb to
0384f0c
Compare
|
@guw I have updated the PR. |
2 participants
Fixes #14
cc @guw