Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Builder: Improve Progress Reporting #433

Closed
cdietrich opened this issue Oct 23, 2017 · 10 comments
Closed

Builder: Improve Progress Reporting #433

cdietrich opened this issue Oct 23, 2017 · 10 comments
Assignees
@holgerschill
Milestone
Release_2.15

Comments

@cdietrich
Copy link
Member

cdietrich commented Oct 23, 2017 •
edited
Loading

we should consider improoving the progress reporting in eclipse during build.
maybe we can facilitate new features in more recent versions once we moved tp to oxygen

e.g. Progress Monitor shows "refeshing" although refreshing has finished before
The Progress Monitor changes its label to "Refreshing" at the places where we call IResource.refreshLocal and keeps that label even after finishing the refresh.
this gives the user the wrong impression all the time is spent on "refreshing"
@cdietrich
Copy link
Member Author

to be checked: is this an issue with platform and is the behaviout still there with oxygen

@cdietrich
Copy link
Member Author

progressmonitor

@cdietrich
Copy link
Member Author

cc @iloveeclipse

@iloveeclipse
Copy link

Christian, I would guess that someone in the call chain of refresh code uses monitor in a wrong way. If this would be a platform bug, we would have more clients complaining.

@cdietrich
Copy link
Member Author

that is the "correct" way of calling?

@iloveeclipse
Copy link

Let say after refresh no one opens new task and the old one is not finished

@cdietrich
Copy link
Member Author

so its not intended to call refresh within a block of other stuff

@iloveeclipse
Copy link

See examples how to use API at https://github.com/iloveeclipse/ece2016-progressmonitors.git

@iloveeclipse
Copy link

so its not intended to call refresh within a block of other stuff

One must inspect the code to answer this

@cdietrich cdietrich changed the title Builder: Progress Monitor shows "refeshing" although refreshing has finished before Builder: Improove Progress Reporting Mar 23, 2018
@cdietrich cdietrich added this to the Release_2.15 milestone Mar 23, 2018
@cdietrich cdietrich modified the milestones: Release_2.15, Release_2.16 Aug 3, 2018
@holgerschill holgerschill changed the title Builder: Improove Progress Reporting Builder: Improve Progress Reporting Aug 29, 2018
@holgerschill holgerschill self-assigned this Aug 29, 2018
holgerschill added a commit that referenced this issue Aug 29, 2018
@holgerschill
Builder: Improve Progress Reporting #433
12427c9
cdietrich pushed a commit that referenced this issue Aug 30, 2018
@holgerschill @cdietrich
Builder: Improve Progress Reporting #433
23b6ed8
holgerschill added a commit that referenced this issue Aug 30, 2018
@holgerschill
Builder: Improve Progress Reporting #433
b87bf85 
Use SubMonitor.split instead of SubMonitor.newChild
Show each file that gets compiled
Don’t show the subTask of Resource.refreshLocal



Signed-off-by: Holger Schill <Holger.Schill@itemis.de>
holgerschill added a commit that referenced this issue Aug 30, 2018
@holgerschill
Builder: Improve Progress Reporting #433
09f77fc 
Use SubMonitor.split instead of SubMonitor.newChild
Show each file that gets compiled
Don’t show the subTask of Resource.refreshLocal



Signed-off-by: Holger Schill <Holger.Schill@itemis.de>
holgerschill added a commit that referenced this issue Aug 30, 2018
@holgerschill
Builder: Improve Progress Reporting #433
d2ee39f 
Use SubMonitor.split instead of SubMonitor.newChild
Show each file that gets compiled
Don’t show the subTask of Resource.refreshLocal
Don’t use chunks any more


Signed-off-by: Holger Schill <Holger.Schill@itemis.de>
holgerschill added a commit that referenced this issue Aug 30, 2018
@holgerschill
Fix review comments on #433
cd508cf
holgerschill added a commit that referenced this issue Aug 30, 2018
@holgerschill
Merge pull request #811 from eclipse/hs/issue433
ebd98f4 
Builder: Improve Progress Reporting #433
@holgerschill
Copy link
Contributor

Fixed in 2.15

@ArneDeutsch ArneDeutsch mentioned this issue Aug 31, 2018
Closed
kthoms pushed a commit that referenced this issue Oct 11, 2018
@holgerschill
Builder: Improve Progress Reporting #433
af35115 
Use SubMonitor.split instead of SubMonitor.newChild
Show each file that gets compiled
Don’t show the subTask of Resource.refreshLocal
Don’t use chunks any more


Signed-off-by: Holger Schill <Holger.Schill@itemis.de>
kthoms pushed a commit that referenced this issue Oct 11, 2018
@holgerschill
Fix review comments on #433
4a2a22c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@holgerschill holgerschill

Labels
None yet
Projects
None yet
Milestone
Release_2.15
Development

No branches or pull requests
3 participants
@cdietrich @holgerschill @iloveeclipse