Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[eclipse/xtext-core#829] Update to Gradle Wrapper 4.9 #830

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

cdietrich
Copy link
Member

[#829] Update to Gradle Wrapper 4.9
Signed-off-by: Christian Dietrich christian.dietrich@itemis.de

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich added this to the Release_2.15 milestone Aug 23, 2018
@cdietrich
Copy link
Member Author

Dont merge yet CQ is still outstanding

Copy link

@kthoms kthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for CQ approval

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.9-bin.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use gradle-4.9-all.zip instead to sport debugging of the build?

@cdietrich
Copy link
Member Author

am not sure. i just a gradle wrapper --gradle-version=4.9 and i am not sure what needs to be called for that?!?

@szarnekow
Copy link
Contributor

We would need to set a different distribution type in the wrapper task. Not sure it's worth it though:
https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html#org.gradle.api.tasks.wrapper.Wrapper:distributionType

Copy link

@kthoms kthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CQ is approved, go!

@cdietrich cdietrich merged commit c9cdfcc into master Aug 27, 2018
@cdietrich cdietrich deleted the cd_issue829 branch August 27, 2018 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants