Update TCK tests for OTel metrics types and units #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/InMemoryMetricReader.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/TelemetryMetricID.java
Show resolved
Hide resolved
...eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/TelemetryHistogramMetric.java
Outdated
Show resolved
Hide resolved
| * @param expectedResultsMillis | ||
| * the list of values which the histogram is expected to have recorded | ||
| */ | ||
| public void assertBucketCounts(long... expectedResultsMillis) { |
There was a problem hiding this comment.
This is a really nice method!
...ava/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/BulkheadTelemetryTest.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/BulkheadTelemetryTest.java
Show resolved
Hide resolved
...eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/TelemetryHistogramMetric.java
Outdated
Show resolved
Hide resolved
Azquelt
force-pushed
the
telemetry-metrics-update
branch
from
efd77b5 to
f9304f9
Compare
- Assert the type of a metric when fetching it. - Avoid summing data points where we only expect one.
Azquelt
force-pushed
the
telemetry-metrics-update
branch
from
e88aa78 to
69304db
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #639, matching the spec changes proposed in #640