Implemented no-op UIs for workspace-composite wizard + preferences #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
|
I've applied the change locally and tested the widgets. They look really nice. Tomorrow I'll have a look at the code. |
donat
requested changes
Mar 26, 2019
There was a problem hiding this comment.
Hi. Good progress! I've made a couple of comments, but all of them are about style and duplication, so the fix should be easy.
Given the size of the PR, I might have missed a few things. but I'd suggest having a second look on the javadocs and the class name consistency. Besides, there might be places where we can reuse an entire GUI page implementation.
...rg/eclipse/buildship/ui/internal/preferences/GradleCompositeImportOptionsPreferencePage.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/buildship/ui/internal/preferences/GradleCompositeImportOptionsPreferencePage.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/buildship/ui/internal/preferences/GradleCompositeImportOptionsPreferencePage.java
Show resolved
Hide resolved
...g/eclipse/buildship/ui/internal/wizard/workspacecomposite/GradleImportOptionsWizardPage.java
Outdated
Show resolved
Hide resolved
...org/eclipse/buildship/ui/internal/wizard/workspacecomposite/GradleRootProjectWizardPage.java
Outdated
Show resolved
Hide resolved
...org/eclipse/buildship/ui/internal/wizard/workspacecomposite/GradleRootProjectWizardPage.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/buildship/ui/internal/wizard/workspacecomposite/HelpContextIdProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/buildship/ui/internal/wizard/workspacecomposite/WizardHelper.java
Outdated
Show resolved
Hide resolved
kuzniarz
force-pushed
the
workspace-composites
branch
from
1b34772
to
9f046f9
Compare
Changed "Gradle Workspace Composite" to "Gradle Composite" Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
kuzniarz
force-pushed
the
workspace-composites
branch
from
9f046f9
to
7490d66
Compare
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Also changed removed FontUtils and fixed javadoc Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Removed all UiBuilder usage. Fixed several javadocs. Added dummy data for checkbox tree. Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
|
@donat I fixed most of the requested changes, the rest requires your opinion |
Had to fix a little layout issue with the GradleProjectGroup Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
|
I'll take a look soon. |
Moved HelpContextIdProvider and WizardHelper to solve class duplication problem. Had to change import for several classes and function visibility of WizardHelper Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
|
Everything should be fixed now! |
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
|
Looks good! I'm going to merge this. |
donat
approved these changes
Apr 12, 2019
donat
pushed a commit
that referenced
this pull request
Apr 12, 2019
) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
donat
pushed a commit
that referenced
this pull request
May 15, 2020
) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
donat
pushed a commit
that referenced
this pull request
Oct 25, 2023
) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
kuzniarz
added a commit
to kuzniarz/buildship
that referenced
this pull request
Feb 8, 2024
…clipse#867) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
donat
pushed a commit
that referenced
this pull request
Apr 19, 2024
) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
donat
pushed a commit
that referenced
this pull request
Apr 19, 2024
) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
donat
pushed a commit
that referenced
this pull request
Apr 19, 2024
) * Implemented no-op UIs for workspace-composite wizard + preferences * Changed workspace composite wizard element name * Changed composite wizard element description * Fixed java doc and useless indent * Javadoc/author fix+ line nitpick * Remove UiBuilder * Fixed indend * Fixed javadoc and indent * Remove UiBuilder/JavaDoc fix * Fixed checkbox tree layout * Refactor HelpContextIdProvider and WizardHelper * Knitpick and format fix Signed-off-by: kuzniarz <sebastian.kuzniarz@dieboldnixdorf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuzniarz sebastian.kuzniarz@dieboldnixdorf.com