fix(zenoh_runtime): disable atexit on windows #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test on zenoh-c seems good. https://github.com/YuanYuYuan/zenoh-c/actions/runs/8846318062/job/24291948644. @fuzzypixelz can you help review this PR? |
fuzzypixelz
approved these changes
Apr 26, 2024
Mallets
approved these changes
Apr 26, 2024
Mallets
added a commit
that referenced
this pull request
Apr 30, 2024
* fix(zenoh_runtime): disable atexit on windows (#981) * Revert "fix(zenoh-runtime): zenoh-c DLL crash in `libc::atexit` handler (#972)" This reverts commit 274166d. * ci: disable atexit cleanup on Windows * fix: Deny publishing of zenoh-ext-examples (#984) * Fix runtime start calling (#985) * Fix invalid JSON in admin space for static plugins (#988) * Fix admin space: plugins __path__ was invalid JSON (#990) * fix(test): sporadic failures of downsampling test on Windows (#995) * fix: set the minimal sleep interval to 17ms on windows * fixup! fix: set the minimal sleep interval to 17ms on windows * fixup! fix: set the minimal sleep interval to 17ms on windows * Acl fix (#993) * ACL does not intercept messages with no key_expr * Update DEFAULT_CONFIG.json5 --------- Co-authored-by: Yuyuan Yuan <az6980522@gmail.com> Co-authored-by: Mahmoud Mazouz <mazouz.mahmoud@outlook.com> Co-authored-by: Julien Enoch <julien.e@zettascale.tech> Co-authored-by: OlivierHecart <olivier@zettascale.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed today, we found that the previous is still problematic. Let's disable the atexit cleanup for the time being.