refactor(protocol-changes): adapt API with protocol changes. #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roughly adapt the code to the new PyO3 API, with a few warning fixes.
evshary
reviewed
Apr 15, 2024
Contributor
evshary
left a comment
evshary
left a comment
There was a problem hiding this comment.
@wyfo I guess we should target on protocol_changes instead of main.
I guess the protocol_changes will not be included into 0.11.0 and should be in 1.0 later.
BTW, I created a PR based on your changes. Not sure you want to merge it into protocol_changes first or maybe I can create another PR after this PR is merged.
ZettaScaleLabs#1
Member
|
@wyfo Please change the base branch to dev/1.0.0 as protocol_changes is no longer the development branch. |
Contributor
Author
|
Closed in favor of #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #175 to be merged before.