Remove default parameters from z_closure #755
Open
+36
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'breaking-change', 'bug', 'internal', 'documentation', 'new feature', 'enhancement'} |
sashacmc
added
bug
sashacmc
force-pushed
the
remove_default_clusure_parameter
branch
from
36a5d9d
to
d7faf9a
Compare
DenisBiryukov91
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default parameters for
z_closurenot implemented in zenoh-c. It's possible to add it (done in PR eclipse-zenoh/zenoh-c#782) , but in fact this functionality is useless in practice: no one will use callbacks without context in real applications. So for simplicity it seems better to remove this, despite that this is slight API change.