Remove const from closure params #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'documentation', 'breaking-change', 'dependencies', 'new feature', 'bug', 'internal', 'enhancement'} |
sashacmc
added
enhancement
12 tasks
sashacmc
force-pushed
the
mutable_closure_params
branch
from
923d8ca
to
0733d7c
Compare
include/zenoh-pico/api/types.h
Outdated
|
|
||
| typedef void (*z_id_handler_t)(const z_id_t *id, void *arg); | ||
| typedef void (*z_id_handler_t)(z_id_t *id, void *arg); |
There was a problem hiding this comment.
z_id_t is non-owned object, there is no benefit in having it non-const, also leads to questions whether the user is in the right to call free on it ?
sashacmc
force-pushed
the
mutable_closure_params
branch
from
bb15e3e
to
55642b1
Compare
DenisBiryukov91
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #647