Use session to create timestamp #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-roland
force-pushed
the
ft_timestamp
branch
from
46a2ccd
to
7db077a
Compare
This reverts commit 45b8273.
src/session/utils.c
Outdated
| @@ -39,8 +39,11 @@ void _z_timestamp_clear(_z_timestamp_t *tstamp) { | |||
| } | |||
|
|
|||
| _Bool _z_timestamp_check(const _z_timestamp_t *stamp) { | |||
| for (uint8_t i = 0; i < sizeof(_z_id_t); ++i) | |||
| if (stamp->id.id[i]) return true; | |||
| for (uint8_t i = 0; i < sizeof(_z_id_t); ++i) { | |||
There was a problem hiding this comment.
I believe it would be better to use here dedicated _z_id_check.
DenisBiryukov91
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502.
This PR revealed an underlying issue regarding timestamps: eclipse-zenoh/zenoh#1239
There might be more work required to make timestamps work on pico.