Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zenoh-C z_slice and z_bytes types compatibility #417

Merged
merged 24 commits into from
Jun 13, 2024
Merged

Zenoh-C z_slice and z_bytes types compatibility #417

merged 24 commits into from
Jun 13, 2024

Conversation

jean-roland
Copy link
Contributor

@jean-roland jean-roland commented Jun 10, 2024 •
edited
Loading

This PR will solve #414.

To-do list:

  • Rename current bytes types as slice types
  • Replace direct slice access with methods z_slice_len and z_slice_data
  • (Re)Introduce bytes type with private internals
  • Introduce methods to encode/decode bytes to and from regular types

@jean-roland jean-roland marked this pull request as ready for review June 12, 2024 09:20
@jean-roland
Copy link
Contributor Author

Could you review it @sashacmc

sashacmc
sashacmc suggested changes Jun 12, 2024
View reviewed changes
examples/arduino/z_sub.ino Outdated Show resolved Hide resolved
include/zenoh-pico/api/types.h Outdated Show resolved Hide resolved
include/zenoh-pico/api/types.h Outdated Show resolved Hide resolved
include/zenoh-pico/api/types.h Outdated Show resolved Hide resolved
include/zenoh-pico/net/encoding.h Show resolved Hide resolved
src/collections/slice.c Show resolved Hide resolved
src/net/sample.c Show resolved Hide resolved
sashacmc
sashacmc approved these changes Jun 12, 2024
View reviewed changes
include/zenoh-pico/collections/slice.h Outdated Show resolved Hide resolved
@milyin milyin merged commit 9aa9ed1 into eclipse-zenoh:dev/1.0.0 Jun 13, 2024
50 checks passed
@jean-roland jean-roland deleted the ft_z_slice branch July 3, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milyin milyin milyin approved these changes

@sashacmc sashacmc sashacmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jean-roland @milyin @sashacmc