Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't tag dry-run releases #239

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Don't tag dry-run releases #239

merged 1 commit into from
Oct 23, 2024

Conversation

fuzzypixelz
Copy link
Member

This breaks the eclipse-zenoh/zenoh release workflow. Bindings have their own bump-and-tag.bash scripts which would need to updated individually.

@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Oct 23, 2024

The diff is large likely because #238 hasn't been merged yet and my node_modules has changed after opening it (hence the failed CI check).

@fuzzypixelz fuzzypixelz added the enhancement New feature or request label Oct 23, 2024
@fuzzypixelz fuzzypixelz marked this pull request as ready for review October 23, 2024 15:44
@fuzzypixelz fuzzypixelz merged commit f089bcc into main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants