Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use names specified by OpenTelemetry for tags #69

Closed
6 tasks done
Tracked by #610
tsegismont opened this issue Dec 8, 2023 · 2 comments
Closed
6 tasks done
Tracked by #610

Use names specified by OpenTelemetry for tags #69

tsegismont opened this issue Dec 8, 2023 · 2 comments
Assignees
@tsegismont
Labels
enhancement New feature or request
Milestone
5.0.0

Comments

@tsegismont
Copy link
Contributor

tsegismont commented Dec 8, 2023 •
edited
Loading

In Vert.x 4, tag names should follow the OpenTracing specification (by convention).

OpenTracing is now deprecated: opentracing/specification#163

In Vert.x 5, tag names should follow the OpenTelemetry specification

This might require to remove/add some adapter code in vertx-tracing (see #70)

Possibly impacted modules
@tsegismont tsegismont added the enhancement New feature or request label Dec 8, 2023
@tsegismont tsegismont added this to the 5.0.0 milestone Dec 8, 2023
@tsegismont tsegismont self-assigned this Dec 8, 2023
This was referenced Dec 8, 2023
Open
Closed
@tsegismont
Copy link
Contributor Author

@vietj how about deprecating OpenTracing in Vert.x 4 and removing in Vert.x 5 ?

@vietj
Copy link
Member

vietj commented Sep 26, 2024

I think we should keep it at least for vertx 5 without publishing docs

tsegismont added a commit to tsegismont/vertx-cassandra-client that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
acb1178 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Sep 26, 2024
Merged
tsegismont added a commit to tsegismont/vertx-redis-client that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
524a968 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Sep 26, 2024
Merged
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
20c5f4f 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Sep 26, 2024
Merged
tsegismont added a commit to tsegismont/vertx-kafka-client that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
027fb6e 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Sep 26, 2024
Merged
tsegismont added a commit to tsegismont/vert.x that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
7c19b6d 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Sep 26, 2024
Merged
tsegismont added a commit to tsegismont/vert.x that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
9bf0cb8 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vert.x that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
498fb14 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vertx-kafka-client that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
08460b4 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vertx-tracing that referenced this issue Sep 26, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
3203899 
See eclipse-vertx#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Sep 26, 2024
Merged
tsegismont added a commit to eclipse-vertx/vert.x that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags (#5331)
1e66109 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to eclipse-vertx/vertx-sql-client that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags (#1468)
4b2ecec 
* Use names specified by OpenTelemetry for tags

See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

* Prevent failures in MySQLUnixDomainSocketTest

Like:

2024-09-26T14:00:19.4493986Z [ERROR] io.vertx.mysqlclient.MySQLUnixDomainSocketTest.connectWithVertxInstance -- Time elapsed: 0.016 s <<< ERROR!
2024-09-26T14:00:19.4496437Z java.util.concurrent.RejectedExecutionException: event executor terminated
2024-09-26T14:00:19.4500928Z 	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:1056)
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

---------

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to vert-x3/vertx-redis-client that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags (#476)
685ce47 
* Use names specified by OpenTelemetry for tags

See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

* CommandReporter provides the operation name

Not the full query string

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

---------

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to vert-x3/vertx-cassandra-client that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags (#86)
9adbc9f 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to vert-x3/vertx-kafka-client that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags (#276)
f82fd40 
See eclipse-vertx/vertx-tracing#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vertx-tracing that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags
3aad71e 
See eclipse-vertx#69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Sep 27, 2024
@tsegismont
Use names specified by OpenTelemetry for tags (#81)
427f3eb 
See #69

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@vietj vietj closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@vietj @tsegismont