Skip to content

Move InMemorySubscriber from L2 to L3 client module #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 24, 2024
Merged

Move InMemorySubscriber from L2 to L3 client module #56

merged 10 commits into from
Jul 24, 2024

Conversation

neelam-kushwah
Copy link
Contributor

@neelam-kushwah neelam-kushwah commented Jul 18, 2024 •
edited
Loading

  • Bug fix: The on_receive method in the UListener class has been updated to be asynchronous. This change resolves an issue in the request handler where responses were sent using the asynchronous send API without being awaited, resulting in failures to receive the response. By making the on_receive method asynchronous, the send API is now properly awaited, thereby fixing the response handling issue.
  • Moved InMemorySubscriber from L2 communication to L3 client module
  • Bump version to 0.2.0 for major release introducing L2 and L3

@github-actions
Copy link

Code coverage report is ready! 📈

@github-actions
Copy link

Code coverage report is ready! 📈

@github-actions
Copy link

Code coverage report is ready! 📈

@github-actions
Copy link

Code coverage report is ready! 📈

DivyaVuppala
DivyaVuppala reviewed Jul 19, 2024
View reviewed changes
@github-actions
Copy link

Code coverage report is ready! 📈

DivyaVuppala
DivyaVuppala reviewed Jul 22, 2024
View reviewed changes
DivyaVuppala
DivyaVuppala reviewed Jul 22, 2024
View reviewed changes
@github-actions
Copy link

Code coverage report is ready! 📈

@DivyaVuppala
Copy link

LGTM

@github-actions
Copy link

Code coverage report is ready! 📈

@github-actions
Copy link

Code coverage report is ready! 📈

@github-actions
Copy link

Code coverage report is ready! 📈

stevenhartley
stevenhartley requested changes Jul 24, 2024
View reviewed changes
Copy link

@stevenhartley stevenhartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@github-actions
Copy link

Code coverage report is ready! 📈

stevenhartley
stevenhartley approved these changes Jul 24, 2024
View reviewed changes
Copy link

@stevenhartley stevenhartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neelam-kushwah neelam-kushwah merged commit 6c0eeb4 into eclipse-uprotocol:main Jul 24, 2024
@neelam-kushwah neelam-kushwah self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenhartley stevenhartley stevenhartley approved these changes

+1 more reviewer

@DivyaVuppala DivyaVuppala DivyaVuppala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@neelam-kushwah neelam-kushwah

Labels

None yet

Projects

Python uProtocol Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neelam-kushwah @DivyaVuppala @stevenhartley