Embed m2e lifecycle-mapping-metadata in Tycho plug-ins #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
approved these changes
Jul 3, 2022
The embedded metadata simply advice M2E to ignore executions of each Tycho Mojo. In the Eclipse IDE Plug-in development support is PDE's duty and therefore Tycho Plug-ins have nothing to do. Because the metadata embedded in a plugin are considered with lowest priority, a user can simply overrule this decision, if it is desired to execute a Tycho Plugin within the IDE. Fixes eclipse-tycho#945
HannesWell
force-pushed
the
m2eLifecycleMappings
branch
from
1761e36
to
a55dca9
Compare
|
Thank you Christoph for your approval. I just updated the xml files to use two-spaces instead of tabs for indentation, which is the default for the generated Xpp3-writers (I had changed that locally and forgot to revert that). For consistency I think we should stick with that default. |
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Jul 3, 2022
The embedded metadata simply advice M2E to ignore executions of each Tycho Mojo. In the Eclipse IDE Plug-in development support is PDE's duty and therefore Tycho Plug-ins have nothing to do. Because the metadata embedded in a plugin are considered with lowest priority, a user can simply overrule this decision, if it is desired to execute a Tycho Plugin within the IDE. Fixes eclipse-tycho#945 Backport of commit f3bc508, added via PR eclipse-tycho#1105
HannesWell
added a commit
that referenced
this pull request
Jul 3, 2022
The embedded metadata simply advice M2E to ignore executions of each Tycho Mojo. In the Eclipse IDE Plug-in development support is PDE's duty and therefore Tycho Plug-ins have nothing to do. Because the metadata embedded in a plugin are considered with lowest priority, a user can simply overrule this decision, if it is desired to execute a Tycho Plugin within the IDE. Fixes #945 Backport of commit f3bc508, added via PR #1105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded metadata simply advice M2E to ignore executions of each Tycho Mojo.
In the Eclipse IDE Plug-in development support is PDE's duty and therefore Tycho Plug-ins have nothing to do.
Because the metadata embedded in a plugin are considered with lowest priority, a user can simply overrule this decision, if it is desired to execute a Tycho Plugin within the IDE.
Providing mappings for all Plug-ins is probably not necessary for most cases, but since theoretically one can explicitly bind a plug-in to any phase, it can also appear in a phase M2E is interested in (i.e. M2E is interested in all phases from validate until before test).
I used the simple app posted to eclipse-m2e/m2e-core#830 to generate all mappings, so they should be complete (I verified that manually).
Fixes #945