Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SSI): adds tolerance to eventual trailing slash in MIW or token URLs #581

Merged
merged 1 commit into from
Jul 7, 2023
Merged

feat(SSI): adds tolerance to eventual trailing slash in MIW or token URLs #581

merged 1 commit into from
Jul 7, 2023

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jul 6, 2023

WHAT

Adds tolerance to eventual trailing slash in MIW or token URLs

WHY

User experience

Closes #580

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wolf4ood wolf4ood marked this pull request as ready for review July 6, 2023 14:24
paullatzelsperger
paullatzelsperger approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually we should collect these sort of utils in a central place

@paullatzelsperger paullatzelsperger merged commit f052433 into eclipse-tractusx:main Jul 7, 2023
@wolf4ood wolf4ood deleted the feat/580_trailing_slash branch July 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuncaytunc-zf tuncaytunc-zf tuncaytunc-zf approved these changes

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSI url settings tolerant to trailing /
3 participants
@wolf4ood @paullatzelsperger @tuncaytunc-zf