Skip to content

feat: implement industry core message service#1143

Open
OlgaIvkovic wants to merge 7 commits into
eclipse-tractusx:feat/data-exchange-request-and-approvalfrom
achtzig20:feat/message-header-interface
Open

feat: implement industry core message service#1143
OlgaIvkovic wants to merge 7 commits into
eclipse-tractusx:feat/data-exchange-request-and-approvalfrom
achtzig20:feat/message-header-interface

Conversation

@OlgaIvkovic
Copy link
Copy Markdown
Contributor

@OlgaIvkovic OlgaIvkovic commented May 4, 2026

Description

  • Add Message header service for creating the header for notification and data exhcange
  • Add validation for requests with the header in their body

Resolves #1133

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files (TRG 7.02
  • Documentation Notice are present on all affected files (TRG 7.07)
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).
  • Changelog updated (changelog.md) with PR reference and brief summary.
  • Frontend version bumped, if needed (frontend/package.json, frontend/package-lock.json)
  • Backend version bumped, if needed (backend/pom.xml)
  • Open API specification updated, if controllers have been changed (use python script scripts/generate_openapi_yaml.py with running customer backend)

Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good job. I made some suggestions for better reusability.

@ReneSchroederLJ ReneSchroederLJ changed the title feat: implement message header service feat: implement industry core message service May 6, 2026
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. I suggested some more potential improvements for better clarity and separation of concerns.

…ge-request-and-approval' into feat/message-header-interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Story] Implement reusable interface for industry core compliant notifications

3 participants