Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve Eslint issues with circular definitions #709

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Solve Eslint issues with circular definitions #709

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edbe6eb
chore: use typescript-specific `no-use-before-define` rule
JKRhb Mar 18, 2022
bea976c
refactor: move definitions before first reference
JKRhb Mar 18, 2022
4a02c07
fix: remove ignored no-use-before-define rules
JKRhb Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove ignored no-use-before-define rules
  • Loading branch information
@JKRhb
JKRhb committed Mar 18, 2022
commit 4a02c07ad961179813ca2c5438fae63b4c409877
2 changes: 0 additions & 2 deletions packages/binding-modbus/src/modbus-connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,7 @@ export class ModbusConnection {
connecting: boolean;
connected: boolean;
timer: NodeJS.Timer; // connection idle timer
// eslint-disable-next-line no-use-before-define
currentTransaction: ModbusTransaction; // transaction currently in progress or null
// eslint-disable-next-line no-use-before-define
queue: Array<ModbusTransaction>; // queue of further transactions
config: {
connectionTimeout?: number;
Expand Down
3 changes: 0 additions & 3 deletions packages/td-tools/src/thing-description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
* SPDX-License-Identifier: EPL-2.0 OR W3C-20150513
********************************************************************************/

// Ignored because of circular definitions
/* eslint-disable no-use-before-define */

// global W3C WoT Scripting API definitions
import * as WoT from "wot-typescript-definitions";

Expand Down