Skip to content

Remove (some) unsused dependencies #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

danielpeintner
Copy link
Member

I used npm-check to identify unsued dependencies. Unfortunately, it gives lots of false positives, and it ends up with trial and error 🤷‍♂️

Anyhow, I managed to get rid of some ..

@danielpeintner
Copy link
Member Author

The test runs are green but eslint suggests adding some (indirect?) dependencies back.

@relu91
Copy link
Member

relu91 commented May 16, 2025

The test runs are green but eslint suggests adding some (indirect?) dependencies back.

I think they are not indirect... they are just not covered by tests (?) For example in helpers we need the dep to check if it is really a ThingModel...

@danielpeintner danielpeintner changed the title Remove unsused dependencies Remove (some) unsused dependencies May 16, 2025
@danielpeintner
Copy link
Member Author

I added some dependencies back. The lights are green now. Please take a look.

For example in helpers we need the dep to check if it is really a ThingModel...

This is somehow problematic I think, and I opened #1384.
Let'd discuss this there...

@danielpeintner
Copy link
Member Author

Do you think it is worth removing those unused dependencies in this PR?

@relu91
Copy link
Member

relu91 commented May 26, 2025

I think it is okay, I have a doubt for @jspm/core which should be needed for correct bundle generation. I have to verify.

@relu91
Copy link
Member

relu91 commented May 28, 2025

In my understanding @jspm/core is needed to integrate the lastest changes from this PR. I'd keep it until we try to migrate directly to a new version of esbuild-plugin-polyfill-node which should be https://www.npmjs.com/package/esbuild-plugins-node-modules-polyfill .

@danielpeintner
Copy link
Member Author

I added @jspm/core@2.1.0 back in browser-bundle

The remaining changes are minimal. I let others decide whether it is still worth to merge...

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (b948e53) to head (65229d9).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
+ Coverage   77.06%   77.29%   +0.22%     
==========================================
  Files          79       79              
  Lines       15290    15290              
  Branches     1442     1442              
==========================================
+ Hits        11783    11818      +35     
+ Misses       3483     3447      -36     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants