Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up commented code-lines #566

Open
danielpeintner opened this issue Oct 13, 2021 · 2 comments
Open

Clean-up commented code-lines #566

danielpeintner opened this issue Oct 13, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@danielpeintner
Copy link
Member

A PR could handle all appearances like the following

#554 (comment)
@danielpeintner danielpeintner mentioned this issue Oct 13, 2021
Merged
@relu91 relu91 added good first issue Good for newcomers enhancement New feature or request labels Feb 15, 2022
@fillobotto
Copy link
Contributor

Is this still valid? As of now I can't spot any piece of commented code.
Just this one https://github.com/eclipse/thingweb.node-wot/blob/master/packages/binding-opcua/test/full-opcua-thing-test.ts#L28

@relu91
Copy link
Member

relu91 commented Apr 8, 2022

Yes, the commented code is still there. Plus I also found commented code in CoapClientTests. Since it is hard to spot commented code it would be fine to clean the blocks that we spotted here.

erossignon added a commit to node-opcua/thingweb.node-wot that referenced this issue Jun 12, 2022
@erossignon
chore(opcua) remove commented code eclipse-thingweb#566
6d532b4
relu91 added a commit that referenced this issue Jun 14, 2022
@relu91
Merge pull request #784 from node-opcua/CleanupCOmmentedOutCode
596dcd0 
chore(opcua) remove commented code #566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@relu91 @fillobotto @danielpeintner