-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track of ESLint Ignored Rules #534
Comments
from @danielpeintner in #589
|
From the PR linked right above: // eslint-disable-next-line @typescript-eslint/no-var-requires
const MbusMaster = require("node-mbus"); |
If I see it correctly, we are targeting ES6 with the TS transpiler at the moment, right? Then I think we could actually disable the rule |
This point has actually been resolved in the meantime, by the way :) |
I have striked through it |
ES6 dates back to ECMAScript 2015. @relu91 any opinion? BTW, I noticed that in .prettierrc.json we still use es5. Shall we change that too? |
Good point, but I think is still a good practice to define stuff before using them (i.e. classes types etc. ). So I would be ok for leaving the rule as it is, but I would not stop you if you think differently :)
Yeah, I think we should. |
Oh, yeah, you are right, I meant only typescript related definitions with the |
This issue is created to keep track of ignored eslint rules with respective justifications.
File/Line:
https://github.com/eclipse/thingweb.node-wot/blob/master/packages/td-tools/src/thing-description.ts
Ignored Rule:
no-use-before-define
Reason: Many circular dependencies where interface/type/class A uses interface/type/class B in its definition and interface/type/class B uses interface/type/class A in its definition.
File/Line:
https://github.com/eclipse/thingweb.node-wot/blob/master/packages/td-tools/src/thing-description.ts
Ignored Rule:
eslint-disable-next-line @typescript-eslint/no-explicit-any
Reason: TD class should be replaced by autogenerated one (see Clean-up of TS definitions in thing-description.ts #529)
CoAP, see 9270d48Netconf, see disabled warnings in disable eslint warnings #818
The text was updated successfully, but these errors were encountered: