Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert iconPath to URL #9608

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Convert iconPath to URL #9608

merged 1 commit into from
Jun 18, 2021

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #9553 by converting the path used for the icon to an endpoint targeting the backend plugin server.

How to test

  1. Install a plugin that has webviews that include icons. (e.g. Gitlens)
  2. Open a webview with an icon (e.g. run command Gitlens: Open Settings)
  3. Observe that the icon for the webview is displayed correctly.

image

Review checklist

Reminder for reviewers

@colin-grant-work
Transform iconPath to url
613f9a3 
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility webviews issues related to webviews labels Jun 18, 2021
vince-fugnitto
vince-fugnitto approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed for both the browser and electron the the webview icon is correctly displayed following the changes 👍

@colin-grant-work colin-grant-work merged commit 319c131 into master Jun 18, 2021
@colin-grant-work colin-grant-work deleted the bugfix/icon-path-endpoints branch June 18, 2021 13:50
@github-actions github-actions bot added this to the 1.15.0 milestone Jun 18, 2021
@jimwu11235 jimwu11235 mentioned this pull request Dec 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Webview iconPath not work when using vscode plugin in electron APP
2 participants
@colin-grant-work @vince-fugnitto