Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is another go at "vscode.Uri.joinPath is not a function" #8752.
The approach (like in the original PR from @svor) is to derive our URI implementation from the vscode-uri implementation we use elsewhere in Theia. In order for this to work, we do the following:
In order to achieve this, I've made the replacer/reviver in rpc-protocol.ts pluggable.
How to test
Same as #9199, but make sure that the errors found post-merge are not occurring (in particular with the Timeline view.
Review checklist
Reminder for reviewers