Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compare editor when working with dirty files #9192

Conversation

kittaakos
Copy link
Contributor

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

This PR fixes the content of the diff editor when working with dirty resources.

How to test

  • Disable the auto-save,
  • Create an empty file,
  • Write foobar in the editor, do not save it.
  • Open Search view, write bar to the search input and baz to the replace input.
  • Double click on the tree item, so that the IDE opens a diff editor.
  • Verify that the right-hand side editor shows foobaz. Without the fix, baz is in the right-hand side editor.

Please review.

Review checklist

Reminder for reviewers

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Mar 12, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the changes fixed the bug as described 👍

@kittaakos
Copy link
Contributor Author

Thank you so much for the review <3

@kittaakos kittaakos merged commit 6afae44 into eclipse-theia:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants