Fix typo in 'Developing.md' #9092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
approved these changes
Feb 19, 2021
Sure. Can I just "commit suggestion" or do I need to make another commit? |
There was a problem hiding this comment.
@Hynn01 please be sure to squash your commits into a single commit with a proper sign-off (so that the eca check does not fail). It can be merged afterwards.
Signed-off-by: Hynn01 <hynn0633@163.com> Remove the extra whitespace Signed-off-by: Hynn01 <hynn0633@163.com>
vince-fugnitto
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
The changes look good to me, thank you @Hynn01 for providing a fix! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hynn01 hynn0633@163.com
What it does
Fixes #9021
How to test
Follow the steps mentioned in #9021
Review checklist
Reminder for reviewers