Fix mini-browser-endpoint missing resource response #8866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doron Nahari doron.nahari@sap.com
What it does
Fix mini-browser-endpoint missing resource response.
![image](https://user-images.githubusercontent.com/24614792/102221889-63f26a00-3eeb-11eb-9468-5c42aa1b48c5.png)
When requiring a resource from the mini-browser such as
<theia-url>/mini-browser/<path-to-resource>
it returns:
And after this fix:
![image](https://user-images.githubusercontent.com/24614792/102221450-dc0c6000-3eea-11eb-9bae-ca612cd683f7.png)
How to test
localhost:3000/mini-browser/<path-to-resource-non-existing-resource>
Before the fix you'll get
200
response code and with the fix you'll get404
Review checklist
Reminder for reviewers