Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: fix disabling breakpoints #8746

Closed
wants to merge 1 commit into from
Closed

debug: fix disabling breakpoints #8746

wants to merge 1 commit into from

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Nov 12, 2020

What it does

Fixes: #8222

The following pull-request fixes an issue where attempting to disable breakpoints during an active debug session would remove the breakpoint rather than disabling it. The fix includes updating the clause which controls whether debug breakpoints should be updated (removed).

debug

How to test

  1. start the application with theia as a workspace
  2. open a *.spec.ts file (ex: cli.spec.ts)
  3. add a breakpoint(s) in the editor
  4. open the debug-view
  5. confirm through the debug view that the breakpoint can be disabled/enabled (through the checkbox)
  6. select the run mocha tests debug configuration
  7. confirm that once the debug session hits the breakpoint, step 5 works
  8. confirm that disabling all breakpoints still works
  9. confirm that removing all breakpoints still works

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The following commit fixes the bug where disabling breakpoints during an
active debug session would remove the breakpoint entirely rather than
simply disabling it.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added bug bugs found in the application debug issues that related to debug functionality labels Nov 12, 2020
@vince-fugnitto vince-fugnitto self-assigned this Nov 12, 2020
@vince-fugnitto
Copy link
Member Author

The following does not work yet when multiple breakpoints are present when starting a debug session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug: breakpoints removed instead of disabled
1 participant