chore(github): Automatically set the milestone on merged PRs #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
documentation
paul-marechal
approved these changes
Oct 14, 2020
kittaakos
approved these changes
Oct 14, 2020
kittaakos
reviewed
Oct 14, 2020
benoitf
force-pushed
the
THEIA-8453
branch
3 times, most recently
from
90107c1 to
9e7c09b
Compare
fixes #8453 Change-Id: I24d730cd7f9fd37b928894ad9ccfd360c2d0b6fa Signed-off-by: Florent Benoit <fbenoit@redhat.com>
azatsarynnyy
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Cool! With this Workflow, getting the info about a release content and a PR's release will be much easier.
One thing that can be improved later is handling the major and bugfix releases. But it should rather be a responsibility of a release script.
Thank you @benoitf Let's try it 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Automatically set milestone when merging Pull Requests
it's using version stored in
@theia/corepackage and bump it using 'minor update`Fixes #8453
How to test
Merge this PR :-)
(if you want to test, you can copy it on your own repository and merge some PRs)
be sure to have a
packages/core/package.jsonfile on this repositoryReview checklist
Reminder for reviewers
Change-Id: I24d730cd7f9fd37b928894ad9ccfd360c2d0b6fa
Signed-off-by: Florent Benoit fbenoit@redhat.com