Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: upgrade to @types/node@12 #8556

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

paul-marechal
Copy link
Member

@paul-marechal paul-marechal commented Sep 24, 2020

Fixes: #8555

How to test

Try importing worker_threads, it should work now.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Sep 24, 2020
@paul-marechal paul-marechal force-pushed the marechal-p/types-node-dependency-8555 branch 2 times, most recently from 25d0b48 to 154532f Compare September 24, 2020 12:41
Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@paul-marechal paul-marechal force-pushed the marechal-p/types-node-dependency-8555 branch from 154532f to 7cca0b6 Compare September 24, 2020 14:30
@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label Sep 24, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the changes locally and they look good to me!
I think we should wait for CI to complete 👍 but there is no rush for the release.

@paul-marechal paul-marechal merged commit 025d633 into master Sep 28, 2020
@paul-marechal paul-marechal deleted the marechal-p/types-node-dependency-8555 branch September 28, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"@types/node" dependency not aligned with Node V12 version
2 participants