Removed getScopedKeybindingsForCommand (no references) #8283
Conversation
vince-fugnitto
added
keybindings
There was a problem hiding this comment.
The changes look good to me:
getScopedKeybindingsForCommandis currently unused (therefore it is untested during development)getScopedKeybindingsForCommandis not tested (no unit tests)
Removing it seems the best course of action for code quality.
To be safe, we can add a breaking change entry in the changelog to advertise it has been removed.
I added the change log entry |
|
@JonasHelming thank you for the contribution, I'll give others a chance to review or comment if they'd like and will likely merge next week if there are no objections 👍 |
|
@JonasHelming do you mind re-pushing (amend), travis seems to be in a weird state 👍 |
|
@JonasHelming can you rebase the pull-request so I can merge tomorrow? |
JonasHelming
force-pushed
the
GH-8270
branch
4 times, most recently
from
0fbf257
to
113a2c4
Compare
done |
fixes eclipse-theia#8270 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
|
@JonasHelming I rebased for you so as not to bother you :) |
|
I actually already rebased it yesterday, maybe you merge soon, as the changelog change will probably run into conflicts almost every day :-) |
fixes #8270
Signed-off-by: Jonas Helming jhelming@eclipsesource.com
What it does
PR removes an unreference function: getScopedKeybindingsForCommand (no updates since 3 years), see #8270 (comment)
By removing the function, #8270 is implicitly fixed
How to test
Nothing to test, removal, nothign should break, though
Review checklist
Reminder for reviewers