Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the default URI label provider customizable. #8281

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

kittaakos
Copy link
Contributor

Downstreams can customize and rebind the default URI label provider.

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

This PR allows downstream consumers to customize and rebind the default URI label provider in their Theia extension.

How to test

Review checklist

Reminder for reviewers

Downstreams can customize and rebind the default URI label provider.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@kittaakos kittaakos merged commit 09ef844 into master Jul 31, 2020
@kittaakos kittaakos deleted the allow-rebind-default-uri-label-provider branch July 31, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants