cli: use proxy settings when downloading plugins #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
enhancement
|
@slhultgren can you tell me if this fixes your issue? It should support all |
paul-marechal
force-pushed
the
mp/proxy-download
branch
2 times, most recently
from
bb36391 to
5bd5c11
Compare
|
@marechal-p Thanks for including the lastError change as well. I tested it and it works well for me. It properly respects the url and uses HTTP_PROXY for http urls and HTTPS_PROXY for https urls. Also ALL_PROXY works as well. |
paul-marechal
force-pushed
the
mp/proxy-download
branch
from
5bd5c11 to
fd0f617
Compare
|
@vince-fugnitto @marcdumais-work just checked the new deps with ClearlyDefined, everything looks good to me. |
paul-marechal
force-pushed
the
mp/proxy-download
branch
2 times, most recently
from
a7c9135 to
8e7ac88
Compare
lastError is always set to undefined at the end of each for-loop iteration, this is not intended behavior. The lastError should persist when exiting the loop -if set-. This commit also simplifies stream piping and error handling. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
request/requestretry used to support some set of proxy environment variables, while node-fetch doesn't by default. This commit add support for proxy settings when downloading plugins. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal
force-pushed
the
mp/proxy-download
branch
from
8e7ac88 to
6786e1f
Compare
vince-fugnitto
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request/requestretry used to support some set of proxy environment
variables, while node-fetch doesn't by default.
This commit add support for proxy settings when downloading plugins.
Fixes #7739
How to test
Review checklist
Reminder for reviewers