support user-defined labels for detected tasks

[elaihau]

• With this change users would be able to define labels in the task configs to overwrite the task names from providers.
• fixes support overwriting the label of detected tasks #6507
• fixes Cannot run configured Task with Label #7515

Signed-off-by: Liang Huang lhuang4@ualberta.ca

How to test

1. define a detected task in your workspace. Mine was defined in package.json as follows:

  "scripts": {
    "list": "sleep 1 && ls"
  },

2. the task defined in Step 1 should show up in the task list as npm: list.
3. customize the label. I added the following config into tasks.json

        {
            "type": "npm",
            "script": "list",
            "label": "NPM LIST CUSTOMIZED LABEL",
            "problemMatcher": []
        },

4. The customized npm: list should show up as NPM LIST CUSTOMIZED LABEL in the task list
5. Check if the customized detected task can be run.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

[vince-fugnitto]

I verified that configured tasks can now define their own custom labels, and that these such tasks still work correctly when executed 👍

[RomanNikitenko]

Hello, Liang!

I tried these changes to define a label for tsc:watch task and it doesn't work for me.

Please let me know if I'm doing something wrong.
Thank you!

[elaihau]

I tried these changes to define a label for tsc:watch task and it doesn't work for me.

Hi Roman thank you for the review, really appreciated !
The bug you found should have been fixed after the most recent patch. @RomanNikitenko

[RomanNikitenko]

Tested after update using tsc:watch task:

• the bug described above was fixed
• a label is correctly applied for all tasks related actions (attach, terminate, configure, restart, show running)
• I don't see any regression

Thanks, Liang!