Hosted plugin - Add support of killing sub treads in Linux run by shell script #7391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idantr
changed the title
akosyakov
requested review from
azatsarynnyy,
RomanNikitenko and
vince-fugnitto
akosyakov
reviewed
Mar 23, 2020
Signed-off-by: Idan Treivish <idan.treivish@sap.com>
|
Tested this PR compared to master in gitpod. It seems that step 2 is not needed as yarn is implemented as sh script already. Without this fix hosted theia leaks those watch processes: With this change everything under yarn watch is killed properly. |
amiramw
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Idan Treivish idan.treivish@sap.com
What it does
Kills Linux sub treads started by shell script link
How to test
PATH should be updated before you start theia
then you can reproduce the issue in local docker
and the test is before and after
Review checklist
Reminder for reviewers