Title: Display Ellipses when content not displayed fully #6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vince-fugnitto all trees should be reviewed |
akosyakov
reviewed
Jan 22, 2020
|
@Anasshahidd21 can you squash your changes to a single commit preserving the appropriate commit message? |
Anasshahidd21
force-pushed
the
anas/6711
branch
from
d738aaa to
310381f
Compare
There was a problem hiding this comment.
@Anasshahidd21 do you think you can handle the tree-view contributed by plugins in this pull request as well? If you rebase this pull request against master you should pick up #6883 which adds some builtin VS Code extensions (like npm)
Anasshahidd21
force-pushed
the
anas/6711
branch
from
310381f to
64a60fd
Compare
|
@Anasshahidd21 ping when you're ready for another review :) |
Anasshahidd21
force-pushed
the
anas/6711
branch
2 times, most recently
from
4533978 to
cf973bf
Compare
Anasshahidd21
force-pushed
the
anas/6711
branch
from
cf973bf to
60e1dd9
Compare
Fixes: eclipse-theia#6711. When the width of the navigator is reduced and the content cannot be displayed completely, then the file name should show ellipses, which currently is not displayed. Fixing one of the css property, fixed the issue. Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21
force-pushed
the
anas/6711
branch
from
60e1dd9 to
09782b2
Compare
vince-fugnitto
approved these changes
Jan 23, 2020
|
please merge |
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #6711
When the width of the navigator is reduced and the content cannot be displayed completely, then the file name should show ellipses, which currently is not displayed. Fixing one of the css property, fixed the issue.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: Muhammad Anas Shahid muhammad.shahid@ericsson.com