support having multiple user-defined problem matchers in tasks.json #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- resolved #6567: With this change Theia support users defining a collection of problem matchers in tasks.json - added json schemas to validate the user-defined problem matchers in tasks.json - fixed the bug with task's schema to allow configured tasks and customized detected tasks in the same tasks.json Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
added
tasks
|
@elaihau |
tolusha
approved these changes
Nov 25, 2019
| let invalidTaskConfig: TaskConfiguration | undefined; | ||
| const validTaskConfigs = taskConfigs.filter(t => { | ||
| const isValid = this.isTaskConfigValid(t); | ||
| if (!isValid) { |
There was a problem hiding this comment.
@elaihau
Looks like you moved this logic to task-configurations.ts.
The difference is:
before the changes this logic was executed every time we took the configured tasks
after: this logic is executed on events like onDidRegisterTaskDefinition
The problem is the logic is not executed when task schema is updated.
This leads to the bug, that some tasks are considered as invalid after updating task schema and are not available for running
There was a problem hiding this comment.
wdyt about the changes https://github.com/eclipse-theia/theia/compare/reorganizeTasks?expand=1
I'm going to test it and create the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code duplication from VS Code was approved in CQ 19787
Signed-off-by: Liang Huang liang.huang@ericsson.com
How to test
prepare a workspace in a Theia setup that has detected tasks. When I tested this change I installed
npmextension that contributes npm tasks.Open / create
.theia/tasks.json, and create a config to customize a detected task. Add a user definedproblemMatcherto the config, and make sure use the array. Mine was{ "type": "npm", "script": "lintAAA", "problemMatcher": [{ "owner": "eslint2", "source": "eslint2", "applyTo": "allDocuments", "fileLocation": "absolute", "pattern": [ { "regexp": "^([^\\s].*)$", "kind": "location", "file": 1 }, { "regexp": "^\\s+(\\d+):(\\d+)\\s+(error|warning|info)\\s+(.+?)(?:\\s\\s+(.*))?$", "line": 1, "column": 2, "severity": 3, "message": 4, "code": 5, "loop": true } ] }] }Review checklist