Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monaco] properly register CodeActionProviders. #6556

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

svenefftinge
Copy link
Contributor

What it does

Registers the providedCodeActionKinds with the CodeactionProvider, which will enable commands that are based on that.

How to test

Install typescript-language-features built-in extension.
Without this change no Organize Import comand is available from quick launch.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added the monaco issues related to monaco label Nov 15, 2019
@svenefftinge svenefftinge force-pushed the se/monaco_codeactionkinds branch 2 times, most recently from d5bd4e7 to 97375bd Compare November 15, 2019 10:30
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organize imports works nicely for me now!

@svenefftinge svenefftinge merged commit eb7749e into master Nov 15, 2019
@svenefftinge svenefftinge deleted the se/monaco_codeactionkinds branch November 15, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants