Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6547 Reload child variable nodes on setValue call. #6555

Merged
merged 1 commit into from
Nov 15, 2019
Merged

#6547 Reload child variable nodes on setValue call. #6555

merged 1 commit into from
Nov 15, 2019

Conversation

ishche
Copy link
Contributor

@ishche ishche commented Nov 15, 2019 •
edited
Loading

What it does

It triggers reload child variables on a value change of parent.

How to test

  1. Have structured variable representation in DAP with dependent child nodes.
  2. Run debug session with a breakpoint in scope.
  3. Change the parent variable.
  4. Observe the update of dependent child variable value.

Review checklist

Reminder for reviewers

@benoitf benoitf requested a review from tolusha November 15, 2019 09:54
@akosyakov akosyakov added the debug issues that related to debug functionality label Nov 15, 2019
tolusha
tolusha approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@tolusha tolusha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.
Works as expected.

@ishche
#6547 Reload child variable nodes on setValue call.
99c4dcf 
Signed-off-by: Yuriy Shekochihin <iurii.shchekochikhin@broadcom.com>
@akosyakov
Copy link
Member

@tolusha please merge if the build is green, code changes looks good to me

@tolusha tolusha merged commit f3d83e2 into eclipse-theia:master Nov 15, 2019
@tolusha tolusha mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@tolusha tolusha tolusha approved these changes

Assignees
No one assigned
Labels
debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishche @akosyakov @tolusha