Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align 'ActionProvider' related entities with VS Code #6302

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Align 'ActionProvider' related entities with VS Code #6302

merged 1 commit into from
Oct 4, 2019

Conversation

RomanNikitenko
Copy link
Contributor

What it does

How to test

Go to Terminal => Run Task menu.
Selected item should contain Configure Task action icon (gear wheel)
gear_wheel

Clicking cog icon should:

  • for detected task - open tasks.json file and copy the configuration
  • for configured one - just open tasks.json

Review checklist

Reminder for reviewers

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@RomanNikitenko
Align 'ActionProvider' related entities with VS Code
9d6bf5f 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko added the tasks issues related to the task system label Oct 1, 2019
@akosyakov
Copy link
Member

@eclipse-theia/task-extension Could you please review and test it?

vince-fugnitto
vince-fugnitto approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works again 👍
I am able to see the action providers (cog icon) when prompted to select a task to run
(run task...). Clicking the icon successfully opens the tasks.json.

I'll give others, perhaps from the @eclipse-theia/task-extension a chance to try it :)

mmorhun
mmorhun approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.
The cog icon is displayed in the current row and by click opens tasks.json

@vparfonov vparfonov mentioned this pull request Oct 2, 2019
Closed
25 tasks
@akosyakov
Copy link
Member

@RomanNikitenko please merge

akosyakov
akosyakov reviewed Oct 4, 2019
View reviewed changes
packages/monaco/src/typings/monaco/index.d.ts
getActions(element: any, item: any): Promise<IAction[]>;
hasSecondaryActions(element: any, item: any): boolean;
getSecondaryActions(element: any, item: any): Promise<IAction[]>;
getActionItem(element: any, item: any, action: IAction): any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less exposed types, awesome!

@RomanNikitenko
Copy link
Contributor Author

@vince-fugnitto @mmorhun
thank you very much for testing and review!

@RomanNikitenko RomanNikitenko merged commit 2186ccb into master Oct 4, 2019
@RomanNikitenko RomanNikitenko deleted the alignActionProvider branch October 4, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@mmorhun mmorhun mmorhun approved these changes

@elaihau elaihau Awaiting requested review from elaihau

Assignees
No one assigned
Labels
tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not configure a task from Terminal => Run Task menu
4 participants
@RomanNikitenko @akosyakov @mmorhun @vince-fugnitto