Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register Monaco keybindings in reverse order #6170

Merged
merged 1 commit into from
Sep 12, 2019
Merged

register Monaco keybindings in reverse order #6170

merged 1 commit into from
Sep 12, 2019

Conversation

akosyakov
Copy link
Member

What it does

fix #6168: register Monaco keybindings in reverse order in order to match to Monaco keybindings dispatch logic

How to test

  • try to navigate between suggest candidates with a keyboard, i.e. with up and down keys
  • also check what there is not regression with escaping from the reference peek widget after following a referenc

Review checklist

Reminder for reviewers

@akosyakov
Copy link
Member Author

@502647092 could you check whether it resolves the issue please?

@akosyakov akosyakov added keybindings issues related to keybindings monaco issues related to monaco labels Sep 12, 2019
in order to match to Monaco keybindings dispatch logic

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeb navigation works nicely for the suggest widget and reference widget. esc closes them properly.
nice!

@502647092
Copy link
Contributor

@502647092 could you check whether it resolves the issue please?

temp

It's work correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

direction key can't select suggest view
3 participants