Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add active effect when click on the tollbar items #6099

Merged
merged 1 commit into from
Sep 4, 2019
Merged

add active effect when click on the tollbar items #6099

merged 1 commit into from
Sep 4, 2019

Conversation

kpge
Copy link
Contributor

@kpge kpge commented Sep 4, 2019

What it does

add click effects to tab-ball-button to show which button clicked, as it does in vscode.
click effect

How to test

  • click button on the toolbar, the button will be increased

Review checklist

Reminder for reviewers

@kpge
add active effect when click on the tollbar items
1998fa9 
Signed-off-by: kpge <gekangping@126.com>
svenefftinge
svenefftinge approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely

@akosyakov akosyakov merged commit 2891e63 into eclipse-theia:master Sep 4, 2019
@kpge kpge deleted the kpge/toolbar-item-mouse-event branch September 4, 2019 11:07
@vince-fugnitto vince-fugnitto mentioned this pull request Jan 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpge @svenefftinge @akosyakov