Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to run dart and flutter vscode extensions #6044

Merged
merged 10 commits into from
Sep 4, 2019
Merged

Fixes to run dart and flutter vscode extensions #6044

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
230c2ed
[vscode] stub an extension kind as a local VS Code extension
akosyakov Aug 24, 2019
73cca79
[debug] ignore additional breakpoints returned by `setBreakpoints` re…
akosyakov Aug 25, 2019
b71fad2
[plugin] implement `Plugin.isActive` check
akosyakov Aug 25, 2019
99e1273
[plugin] implement selection and visible tree view APIs
akosyakov Aug 25, 2019
cfda1b4
fix #6039: implement vscode.env.openExternal API
akosyakov Aug 26, 2019
f34d20c
[plugin] list `onUri` as a supported activation event
akosyakov Aug 26, 2019
67a04cb
fix #6083: optimize tab bar decorations rendering
akosyakov Sep 2, 2019
737d348
fix #6084: optimize problem status rendering
akosyakov Sep 2, 2019
a2cc0ee
[plugin] fix #6091: pass proper document change rangeOffset
akosyakov Sep 3, 2019
6b80981
[plugin] fix #6092: make sure command arguments are passed safely via…
akosyakov Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[debug] ignore additional breakpoints returned by setBreakpoints re… 
…quest

otherwise it fails `undefined` and swallows updates for other breakpoints

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
  • Loading branch information
@akosyakov
akosyakov committed Sep 4, 2019
commit 73cca79b408acfbc5f3b40aa9e4d05e01e28a283
7 changes: 6 additions & 1 deletion packages/debug/src/browser/debug-session.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,12 @@ export class DebugSession implements CompositeTreeElement {
sourceModified,
breakpoints: enabled.map(({ origin }) => origin.raw)
});
response.body.breakpoints.map((raw, index) => enabled[index].update({ raw }));
response.body.breakpoints.map((raw, index) => {
// node debug adapter returns more breakpoints sometimes
if (enabled[index]) {
enabled[index].update({ raw });
}
});
} catch (error) {
// could be error or promise rejection of DebugProtocol.SetBreakpointsResponse
if (error instanceof Error) {
Expand Down