Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance Debugging #5774

Merged
merged 12 commits into from
Jan 1, 2020
Merged

Advance Debugging #5774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c889bca
[debug] fix #5769: watch support
akosyakov Jul 22, 2019
05bd53e
[debug] fix #5768: exception breakpoints support
akosyakov Jul 23, 2019
eb37b3f
[debug] added function breakpoints support
akosyakov Jul 24, 2019
e440b34
[debug] fix ##3807: added inline breakpoints support
akosyakov Jul 25, 2019
f58c5af
Fix after rebasing on master
tolusha Dec 6, 2019
fa35b08
Small fixes
tolusha Dec 6, 2019
e3606fc
Fix debug menu
tolusha Dec 6, 2019
379c948
Rename inlineBreakpoint -> getInlineBreakpoint
tolusha Dec 9, 2019
e8e3f7b
Add license to icons
tolusha Dec 9, 2019
9bbcc4c
Show Exception widget if topframe doesn't have source
tolusha Dec 9, 2019
2b2e97e
Add license to all copied icons
tolusha Dec 11, 2019
43b344d
[theming] apply debug exception widget colors
akosyakov Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[theming] apply debug exception widget colors 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
  • Loading branch information
@akosyakov
akosyakov committed Jan 1, 2020
commit 43b344d70819d7a8b84c7cabe12ef30d54d76f8c
11 changes: 11 additions & 0 deletions packages/debug/src/browser/debug-frontend-application-contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,17 @@ export class DebugFrontendApplicationContribution extends AbstractViewContributi
light: 'statusBar.border',
hc: 'statusBar.border'
}, description: 'Status bar border color separating to the sidebar and editor when a program is being debugged. The status bar is shown in the bottom of the window'
},
// Debug Exception Widget colors should be aligned with
// https://github.com/microsoft/vscode/blob/ff5f581425da6230b6f9216ecf19abf6c9d285a6/src/vs/workbench/contrib/debug/browser/exceptionWidget.ts#L23
{
id: 'debugExceptionWidget.border', defaults: {
dark: '#a31515', light: '#a31515', hc: '#a31515'
}, description: 'Exception widget border color.',
}, {
id: 'debugExceptionWidget.background', defaults: {
dark: '#420b0d', light: '#f1dfde', hc: '#420b0d'
}, description: 'Exception widget background color.'
}
);
}
Expand Down
2 changes: 0 additions & 2 deletions packages/debug/src/browser/style/debug-bright.useable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,4 @@
--theia-debug-configure: url('configure.svg');
--theia-debug-repl: url('repl.svg');
--breakpoints-activate-url: url('breakpoints-activate.svg');
--theia-debug-exception-widget-border-color: #a31515;
--theia-debug-exception-widget-background-color: #f1dfde;
}
2 changes: 0 additions & 2 deletions packages/debug/src/browser/style/debug-dark.useable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,4 @@
--theia-debug-configure: url('configure-inverse.svg');
--theia-debug-repl: url('repl-inverse.svg');
--breakpoints-activate-url: url('breakpoints-activate-inverse.svg');
--theia-debug-exception-widget-border-color: #a31515;
--theia-debug-exception-widget-background-color: #420b0d;
}
8 changes: 4 additions & 4 deletions packages/debug/src/browser/style/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,13 +399,13 @@

/** Exception Widget */
.monaco-editor .zone-widget .zone-widget-container.theia-debug-exception-widget {
color: var(--theia-content-font-color0);
color: var(--theia-editor-foreground);
font-size: var(--theia-code-font-size);
line-height: var(--theia-code-line-height);
font-family: var(--theia-code-font-family);
border-top-color: var(--theia-debug-exception-widget-border-color);
border-bottom-color: var(--theia-debug-exception-widget-border-color);
background-color: var(--theia-debug-exception-widget-background-color);
border-top-color: var(--theia-debugExceptionWidget-border);
border-bottom-color: var(--theia-debugExceptionWidget-border);
background-color: var(--theia-debugExceptionWidget-background);
padding: var(--theia-ui-padding) calc(var(--theia-ui-padding)*1.5);
white-space: pre-wrap;
user-select: text;
Expand Down