New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tabbing outside of dialog overlay #14647

Open

martin-fleck-at wants to merge 1 commit into master from GH-9894

Contributor

martin-fleck-at commented Dec 18, 2024

What it does

Fixes #9894

How to test

Use TAB and SHIFT+TAB to navigate through tabbable elements in the DOM
Open a dialog (e.g., New Folder) and verify that if a dialog is open we only tab through elements within that dialog
Close and re-open dialog to see if tabbing only every works on expected elements

Follow-ups

Breaking changes

This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines


          Prevent tabbing outside of dialog overlay

4891fa2

Fixes #9894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet