Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports when importing ReactDialog #14352

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix circular imports when importing ReactDialog
Fixes #14347

Contributed on behalf of Toro Cloud

Signed-off-by: Rannie Peralta <rannie.peralta@torocloud.com>
  • Loading branch information
rannp-toro-cloud committed Oct 25, 2024
commit 257cee7a34a8ab0c0c6f3c6d1d4e0d2e5bf8d105
2 changes: 1 addition & 1 deletion packages/core/src/browser/dialogs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import { injectable, inject } from 'inversify';
import { Disposable, MaybePromise, CancellationTokenSource, nls } from '../common';
import { Key } from './keyboard/keys';
import { Widget, BaseWidget, Message, addKeyListener, codiconArray } from './widgets';
import { Widget, BaseWidget, Message, addKeyListener, codiconArray } from './widgets/widget';
import { FrontendApplicationContribution } from './frontend-application-contribution';

@injectable()
Expand Down
31 changes: 31 additions & 0 deletions packages/core/src/browser/dialogs/react-dialog.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { expect } from 'chai';
import * as React from 'react';
import { enableJSDOM } from '../test/jsdom';

let disableJSDOM = enableJSDOM();

import { ReactDialog } from './react-dialog'

class MyDialog extends ReactDialog<void> {
constructor() {
super({ title: '' })
}

override get value(): void {
return;
}

protected override render(): React.ReactNode {
return <></>
}
}

describe('ReactDialog', () => {
before(() => disableJSDOM = enableJSDOM());
after(() => disableJSDOM());

it('should be extended', () => {
const dialog = new MyDialog()
expect(dialog).to.be.instanceOf(ReactDialog)
})
})
Loading