Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook API Support #12442

Merged
merged 94 commits into from
Aug 31, 2023
Merged

Notebook API Support #12442

Changes from 1 commit
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
b17fe8a
Add notebook package to Theia
msujew Feb 27, 2023
e60b44f
working getting notebook contributions
jonah-iden Feb 28, 2023
0e5f2b6
working onNotebook activation event;
jonah-iden Mar 1, 2023
c84990b
basic backend frontend communication with registering serializers
jonah-iden Mar 3, 2023
a98e3b1
render messaging rpc api
jonah-iden Mar 3, 2023
76bf6e8
basic widget for notebooks working
jonah-iden Mar 9, 2023
77230ba
titles for noetbook editor + and working language support for cell ed…
jonah-iden Mar 10, 2023
0f0d9dc
fixed activating serializers before opening notebook document; added …
jonah-iden Mar 27, 2023
63ff3eb
notebook document dirty and save listeners
jonah-iden Mar 27, 2023
a450866
document dirty and save listeners
jonah-iden Mar 27, 2023
ecadf6c
baisc saving of notebooks implemented
jonah-iden Mar 28, 2023
ba6ca53
basic toolbar implementation for selected cell
jonah-iden Mar 30, 2023
2c989f1
notebook edit framework and edit and delete actions
jonah-iden Mar 31, 2023
a301b32
context key basics
jonah-iden Apr 11, 2023
d0e5726
notebook editor closable; removed when clause since no support for it…
jonah-iden Apr 11, 2023
ff50115
fixed saving
jonah-iden Apr 11, 2023
6ffcbd4
hardcoded flag for deactivating unfinished notebook support
jonah-iden Apr 11, 2023
3e09a16
basic add cell buttons (no functionality)
jonah-iden Apr 11, 2023
3f3ea80
all smaller review comments
jonah-iden Apr 19, 2023
409f36d
notebookModel and notebookCellModel injectable
jonah-iden Apr 19, 2023
2df5b29
better dependency injection for notebookEditor widget and the cell re…
jonah-iden Apr 19, 2023
6513d4f
fixed activation events. explicit onNotebook, implicit on NotebookSer…
jonah-iden Apr 20, 2023
d493d0b
correct dirty change after saving
jonah-iden Apr 20, 2023
c675a88
updated notebook package to 1.36.0
jonah-iden Apr 20, 2023
82f20d6
removed uneccessary comment
jonah-iden Apr 21, 2023
7461bd9
react key for cellDivider
jonah-iden Apr 21, 2023
04f6830
removed duplicate interface
jonah-iden Apr 21, 2023
edf747c
update notebook packege to 1.37.0
jonah-iden May 2, 2023
43e9058
review comments
jonah-iden May 19, 2023
157b49e
stop using createInline()
jonah-iden May 26, 2023
c19dd8c
more review comment changes:
jonah-iden May 26, 2023
80deb5e
renamed Event
jonah-iden Jun 12, 2023
7870a2b
updated version to 1.38.0
jonah-iden Jun 16, 2023
39a299b
basics for notebook ContextKeys implemented
jonah-iden Jun 19, 2023
73321be
context keys working for cells
jonah-iden Jun 19, 2023
9c4b12b
cell toolbar menu item order; fixed cell editor sizing
jonah-iden Jun 20, 2023
c394140
added basic logic for adding new cells
jonah-iden Jun 20, 2023
b6529ca
fixed file headers
jonah-iden Jun 20, 2023
0b9fc42
include vscode.ipynb by default
jonah-iden Jun 22, 2023
3809ce2
basiscs for notebook cell Execution API
jonah-iden Jun 22, 2023
a3b01e4
basic api for cell execution and jupyter extension support
jonah-iden Jun 29, 2023
77ca418
basic kernel creation and selection
jonah-iden Jul 13, 2023
021a227
increased version to 1.39.0
jonah-iden Jul 13, 2023
8e5a462
basic showing cell outputs
jonah-iden Jul 14, 2023
7247029
cleanup, correct cell updating and basic api for notebook-edits (not …
jonah-iden Jul 17, 2023
928161c
fixed Element already has context attribute Error
jonah-iden Jul 17, 2023
3195f48
fixed cell document odes allready exists error
jonah-iden Jul 19, 2023
35849da
fixed notebook not scrollable when mouse in editor
jonah-iden Jul 19, 2023
6e3079e
api and contributions for notebook renderers
jonah-iden Jul 20, 2023
cb7dc84
Improve editor performance
msujew Jul 24, 2023
cdd8739
basic cell rendering in iframes working
jonah-iden Jul 26, 2023
7ea5f8f
actually fixed document allready exists error
jonah-iden Jul 26, 2023
3a7f070
only display output webview when outputs
jonah-iden Jul 26, 2023
a1f5f8c
some fixes for displaying outputs
jonah-iden Jul 26, 2023
d237e9e
small fix for images, so the output height is determined correctly
jonah-iden Jul 27, 2023
49ec33c
scrolling propagation from output webview to parent working
jonah-iden Jul 28, 2023
f37cce4
smaller output layouting changes
jonah-iden Jul 28, 2023
8e08f1c
added sidebar menu for cells
jonah-iden Jul 28, 2023
098077d
Improve a few rendering issues, cleanup CSS
msujew Jul 28, 2023
0545249
Fix notebook widget startup rendering
msujew Jul 28, 2023
ac5244a
working sidebar and change presentation for outputs
jonah-iden Jul 31, 2023
f6ca0dd
merge issue fixes
jonah-iden Jul 31, 2023
4220260
quickfix for ouput action menu
jonah-iden Jul 31, 2023
e62a686
small fix for ouput webview horizontal size
jonah-iden Jul 31, 2023
a1ed1ca
fix for previous css fix
jonah-iden Jul 31, 2023
65b58bf
save outputs and notebook dirty on output change
jonah-iden Jul 31, 2023
1233170
basic cell status view (still kind of bugged
jonah-iden Aug 1, 2023
e2f5699
fixed notebook code-cell status-bar
jonah-iden Aug 2, 2023
9cbf5ac
renamed Dto methods since they dont
jonah-iden Aug 2, 2023
13e5746
fixed issue with no document found when notebook is restored
jonah-iden Aug 2, 2023
7b18f0f
basic notebook toolbar
jonah-iden Aug 7, 2023
305f4fc
working kernel chooser
jonah-iden Aug 7, 2023
1880a57
persisting kernel selection
jonah-iden Aug 7, 2023
c02e5a6
upgraded notebook to 1.40
jonah-iden Aug 7, 2023
26b2324
fixed no document error with adding new code cell;
jonah-iden Aug 8, 2023
f00e110
added notebook/cell/execution contribution menu;
jonah-iden Aug 9, 2023
3c1664a
basic undo redo for notebook-editor
jonah-iden Aug 9, 2023
fbf1662
fixes for setting current active editor
jonah-iden Aug 9, 2023
976741c
added drag and drop moving of cells
jonah-iden Aug 10, 2023
1527850
Set editor dirty on any edit operation
msujew Aug 11, 2023
55a5435
Fix formatting
msujew Aug 11, 2023
04859d7
Fix notebook editor resize behavior
msujew Aug 11, 2023
474faf9
Fix broken monaco editor
msujew Aug 11, 2023
9cb19ff
removed @stubbed for most of notebook-api;
jonah-iden Aug 11, 2023
6a0a3b9
fixed build for api changes
jonah-iden Aug 11, 2023
374dcdb
fixed lint
jonah-iden Aug 11, 2023
ab1727a
basics for creating new untitled notebooks
jonah-iden Aug 11, 2023
e8dd288
Fix issues after latest commit
msujew Aug 16, 2023
0ef597d
Don't cache matched notebook types
msujew Aug 16, 2023
f3a031c
fixed multiple smaller issues
jonah-iden Aug 22, 2023
6409051
basic wokring creating new empty notebook;
jonah-iden Aug 23, 2023
a89eb2e
basic saveAs functionality for untitle notebooks
jonah-iden Aug 23, 2023
b7fcb31
Fix bugs, typos, and improve notebook behavior
msujew Aug 25, 2023
9add50f
Fix notebook header rendering
msujew Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed uneccessary comment 
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
  • Loading branch information
@jonah-iden
jonah-iden committed Aug 23, 2023
commit 82f20d63b4b746efb756d6814a5dd8e1b3c57fdf
2 changes: 1 addition & 1 deletion packages/notebook/src/browser/contributions/notebook-context-keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class NotebookContextKeyService {
service.createKey(NOTEBOOK_CELL_MARKDOWN_EDIT_MODE, false);
service.createKey(NOTEBOOK_CELL_LINE_NUMBERS, 'inherit');
service.createKey(NOTEBOOK_CELL_EXECUTION_STATE, undefined);
service.createKey(NOTEBOOK_CELL_EXECUTING, false); // This only exists to simplify a context key expression, see #129625
service.createKey(NOTEBOOK_CELL_EXECUTING, false);
service.createKey(NOTEBOOK_CELL_HAS_OUTPUTS, false);
service.createKey(NOTEBOOK_CELL_INPUT_COLLAPSED, false);
service.createKey(NOTEBOOK_CELL_OUTPUT_COLLAPSED, false);
Expand Down