Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coding-guidelines and code-organization files #11529

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Aug 4, 2022

What it does

Moves coding guidelines and code organization docs to the repo.

Fixes #11528

How to test

Review checklist

Reminder for reviewers

Signed-off-by: Thomas Mäder <tmader@redhat.com>
doc/pull-requests.md Outdated Show resolved Hide resolved
@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Aug 4, 2022
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of minor copy editing.

doc/code-organization.md Outdated Show resolved Hide resolved
doc/code-organization.md Outdated Show resolved Hide resolved
doc/code-organization.md Outdated Show resolved Hide resolved
doc/code-organization.md Outdated Show resolved Hide resolved
doc/coding-guidelines.md Outdated Show resolved Hide resolved
doc/coding-guidelines.md Outdated Show resolved Hide resolved
doc/coding-guidelines.md Outdated Show resolved Hide resolved
doc/coding-guidelines.md Outdated Show resolved Hide resolved
doc/coding-guidelines.md Outdated Show resolved Hide resolved
doc/coding-guidelines.md Outdated Show resolved Hide resolved
tsmaeder and others added 4 commits August 5, 2022 09:58
Co-authored-by: colin-grant-work <colin.grant@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: colin-grant-work <colin.grant@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me 👍

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colin-grant-work
Copy link
Contributor

@tsmaeder, are we waiting on anything in particular to merge this one?

@tsmaeder tsmaeder merged commit 8fe2a50 into eclipse-theia:master Sep 9, 2022
@vince-fugnitto vince-fugnitto added this to the 1.30.0 milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move coding guidelines to docs/coding-guidelines.md
3 participants