Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion are rendered with lineHeight of 1 #937

Closed
svenefftinge opened this issue Dec 4, 2017 · 0 comments · Fixed by #939
Closed

Suggestion are rendered with lineHeight of 1 #937

svenefftinge opened this issue Dec 4, 2017 · 0 comments · Fixed by #939
Assignees
@svenefftinge
Labels
bug bugs found in the application
Milestone
Theia BETA

Comments

@svenefftinge
Copy link
Contributor

In 0.2.4 the suggest widget is broken, because the editor.suggestLineHeight is 1.5 by default
@svenefftinge svenefftinge self-assigned this Dec 4, 2017
@svenefftinge svenefftinge added the bug bugs found in the application label Dec 4, 2017
@svenefftinge svenefftinge added this to the Theia BETA milestone Dec 4, 2017
svenefftinge added a commit that referenced this issue Dec 4, 2017
@svenefftinge
[editor preferences] Removed styling related preferences (should be h…
0650a9f 
…andled with theming) and removed redeclaration of monaco’s default values to avoid running out of sync (fixes #937).

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@svenefftinge svenefftinge mentioned this issue Dec 4, 2017
Merged
svenefftinge added a commit that referenced this issue Dec 4, 2017
@svenefftinge
[editor preferences] Removed styling related preferences
1041a0c 
Removed styling related preferences (should be handled with theming) and removed redeclaration of monaco’s default values to avoid running out of sync (fixes #937).

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Dec 4, 2017
@svenefftinge
[editor preferences] Removed styling related preferences
237206a 
Removed styling related preferences (should be handled with theming) and removed redeclaration of monaco’s default values to avoid running out of sync (fixes #937).

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenefftinge svenefftinge

Labels
bug bugs found in the application
Projects
None yet
Milestone
Theia BETA
Development

Successfully merging a pull request may close this issue.

[editor preferences] Removed styling related preferences eclipse-theia/theia
1 participant
@svenefftinge